-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 generalize downloader #13
base: main
Are you sure you want to change the base?
Conversation
…der experiment/scenario set, remove some defaults that result in unituitive results, add some failure points where needed, add naive approach for scenario handling
I haven't run the tests yet and I can already see that the linters are failing here (it worked locally for me though). I just wanted to make sure that you have access to the latest version and can look into the changes. And I think it would be good to merge current changes before I continue adapting the downloader further. With those changes all my cmip6 test cases are now working (6/6), so that's already a big step :D |
…sgf.py. split up raw and model vars. remove unused constants.
…g. update attribute handling of class. rewrite some if-else blocks. unify model and raw input vars handling. update constants. rename emission handling funcs. add comments for attributes in downloader class.
I am creating a pull request, so the branches are not splitting up too much over time.
Current state:
The other future_cases are not working yet and have not been implemented yet. Please ignore those.
Next immediate steps: (Input4Mips handling)
Other next steps:
Backlog: