Skip to content

Commit 4b187cd

Browse files
authored
MNT: declare dependency floors the package can actually run on (#1108)
`scipy>=1.0` is not true. `monte_carlo.py` imports `scipy.stats.bootstrap` at module level, and the SciPy 1.7.0 release notes are where that arrives, so anything from 1.0 to 1.6 satisfies the floor and then fails on `import rocketpy`. `numpy>=1.13` is not true either, and the binding constraint turned out to be a sibling rather than NumPy itself: `matplotlib>=3.9.0` requires `numpy>=1.23`. SciPy then has to be new enough to allow that, and 1.7.2 caps NumPy at `<1.23.0`, so 1.8 is the first that composes. Verified rather than reasoned. On Python 3.10 with numpy 1.23.0 and scipy 1.8.0 pinned and everything else current, `import rocketpy` works and `tests/unit/simulation` with `tests/unit/stochastic` is 162 passed, 5 skipped. At numpy 1.21.3, which is where NumPy's own cp310 wheels start, matplotlib refuses to import. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
1 parent a586750 commit 4b187cd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
numpy>=1.13
2-
scipy>=1.0
1+
numpy>=1.23 # matplotlib 3.9 requires it
2+
scipy>=1.8 # first to allow numpy 1.23; bootstrap needs 1.7
33
matplotlib>=3.9.0 # Released May 15th 2024
44
netCDF4>=1.6.4
55
requests

0 commit comments

Comments
 (0)