Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): value is always an array when multiple is true #1314

Merged
merged 2 commits into from
May 1, 2024

Conversation

micahjones13
Copy link
Collaborator

Brief Description

Fixes an issue where a multi-select could have a string value instead of an array value if only one option was present.

JIRA Link

Related Issue

Customer email.

General Notes

Motivation and Context

Makes select menu act as our docs state: If multiple is true, value is an array.

Issues and Limitations

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 4e3a352

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 1, 2024

Deploy Preview for astro-preview canceled.

Name Link
🔨 Latest commit 4e3a352
🔍 Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/663262724a65690008b473de

Copy link

netlify bot commented May 1, 2024

Deploy Preview for astro-stencil canceled.

Name Link
🔨 Latest commit 4e3a352
🔍 Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/66326272f412960008d6a165

@micahjones13 micahjones13 merged commit 2ac99dd into main May 1, 2024
7 checks passed
@micahjones13 micahjones13 deleted the mj.select-mult-fix branch May 1, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants