Skip to content

Commit

Permalink
Fixes after eventemitter3 migration (#698)
Browse files Browse the repository at this point in the history 
* Missed EventEmitter2 in es6 transpiler

* (README) EventEmitter2 -> 3

* (examples) EventEmitter2 -> 3
  • Loading branch information
@MatthijsBurgh
MatthijsBurgh authored Oct 18, 2024
1 parent bde0004 commit f3ce39a
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Alternatively, you can use the current release via the [JsDelivr](https://www.js

ros3djs depends on:

[EventEmitter2](https://github.com/hij1nx/EventEmitter2). The current supported version is 6.4. The current supported version can be found on the JsDeliver CDN: ([full](https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js)) | ([min](https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.min.js))
[EventEmitter3](https://github.com/primus/eventemitter3). The current supported version is 5.0. The current supported version can be found on the JsDeliver CDN: ([full](https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.js)) | ([min](https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.js))

[three.js](https://github.com/mrdoob/three.js/). The current supported version is r89. The current supported version can be found on the Robot Web Tools CDN: ([full](https://cdn.jsdelivr.net/npm/[email protected]/build/three.js)) | ([min](https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js))

Expand Down
2 changes: 1 addition & 1 deletion es6-transpiler.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ const transpile = {
],
// Track external dependencies for import injection
externalDependencies: (filepath) => [
/(.*)(THREE|EventEmitter2|ROSLIB|ColladaLoader|OBJLoader|MTLLoader|STLLoader).*/g,
/(.*)(THREE|EventEmitter3|ROSLIB|ColladaLoader|OBJLoader|MTLLoader|STLLoader).*/g,
(match, $preStuffs, $dep) => {

if (/^\s*(?:\*|\/\/)/.test($preStuffs)) {
Expand Down
2 changes: 1 addition & 1 deletion examples/continuousmap.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/depthcloud.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/interactivemarkers.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/kitti.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/map.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/markers.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/navsatfix.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/octree.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/pointcloud2.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />

<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion examples/urdf.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<script src="https://cdn.jsdelivr.net/npm/[email protected]/build/three.min.js"></script>
<!-- <script src="https://static.robotwebtools.org/threejs/current/ColladaLoader.js"></script> --><!-- CDN is gone -->
<!-- <script src="https://static.robotwebtools.org/threejs/current/STLLoader.js"></script> --><!-- CDN is gone -->
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/eventemitter2.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/eventemitter3.umd.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.js"></script>
<script src="../build/ros3d.js"></script>
<script src="js/ColladaLoader.js"></script> <!-- override the default ColladaLoader -->
Expand Down

0 comments on commit f3ce39a

Please sign in to comment.