-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sudo from READMEs #359
Comments
I noticed this in #357. It's OK by me if you'd like to merge the correct documentation first (which currently means telling the user to run sudo) and then circle back here later. (However, that might be difficult in case macOS requires no-sudo but Ubuntu requires yes-sudo, and they share the same README.) |
I was just reviewing this on #357. I believe the |
That's the right idea, we could call it 90% of the way there. The problem is that if someone is running in Docker and they are already root, sometimes The ideal would be to only run maybe_sudo=
if [[ "${EUID}" -ne 0 ]]; then
maybe_sudo=sudo
fi
${maybe_sudo} apt-get ...etc... |
That makes sense, thanks for the clarification. On closer inspection, it seems that the examples are not consistent. Some of the examples, like |
For any scripts in this repository, if they require root access then they should internally obtain that access (e.g., by conditionally prefixing certain commands like
apt-get
with asudo
). They should not instruct the user to runsudo setup/install_prereqs
.This is the policy Drake will be aiming for, moving forward (see e.g. RobotLocomotion/drake#22461).
The text was updated successfully, but these errors were encountered: