Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actionlib needs patch #2

Open
Tobias-Fischer opened this issue Aug 26, 2020 · 3 comments
Open

actionlib needs patch #2

Tobias-Fischer opened this issue Aug 26, 2020 · 3 comments

Comments

@Tobias-Fischer
Copy link
Collaborator

Tobias-Fischer commented Aug 26, 2020

  • /actionlib/library.py", line 170, in _message_to_yaml: if type(msg) in [int, long, float, str, bool]: needs change to if type(msg) in [int, float, str, bool]:
  • from cStringIO import StringIO needs change to from io import BytesIO
@wolfv
Copy link
Member

wolfv commented Aug 26, 2020

I wonder if we should really try to patch melodic enough to work reasonably with python 3 or if we should just rebuild wiht python 2.7?
Or maybe we should have both versions available, at least, and say that py 3.6 is more experimental.

@Tobias-Fischer
Copy link
Collaborator Author

I think python3 with melodic would be one of the big selling points for conda with Ros. We might run into issues with the python2 build, too, especially as packages aren't built by default with python2 on conda forge anymore. But we certainly will run into more of those issues. Not sure what's the best way forward :(

@Tobias-Fischer
Copy link
Collaborator Author

This particular case could be patched with: ros/actionlib#169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants