Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fake a 404 for non-ajax requests #46

Open
RobertHeim opened this issue Feb 27, 2015 · 0 comments
Open

don't fake a 404 for non-ajax requests #46

RobertHeim opened this issue Feb 27, 2015 · 0 comments
Labels
Milestone

Comments

@RobertHeim
Copy link
Owner

When symfony2 is updated to at least 2.4 ( which will take until phpbb 3.2 ( https://www.phpbb.com/community/viewtopic.php?f=461&t=2300491 )
we should use routing-conditions

like this: http://stackoverflow.com/a/21661883/386201
here:

// TODO: when symfony2 is updated to at least 2.4 add to route:
// condition: "context.isXmlHttpRequest()" instead of using the helper->error(..., 404)

instead of faking a 404 here:

return $this->helper->error('No route found for "' . $this->helper->get_current_url() . '"' , 404);

@RobertHeim RobertHeim added this to the later milestone Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant