Skip to content

Commit 67ce817

Browse files
authored
Add peer.service attribute to symfony http client spans (open-telemetry#302)
1 parent 3a66cc8 commit 67ce817

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/Instrumentation/Symfony/src/HttpClientInstrumentation.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public static function register(): void
5252
->tracer()
5353
->spanBuilder(\sprintf('%s', $params[0]))
5454
->setSpanKind(SpanKind::KIND_CLIENT)
55+
->setAttribute(TraceAttributes::PEER_SERVICE, parse_url((string) $params[1])['host'] ?? null)
5556
->setAttribute(TraceAttributes::URL_FULL, (string) $params[1])
5657
->setAttribute(TraceAttributes::HTTP_REQUEST_METHOD, $params[0])
5758
->setAttribute(TraceAttributes::CODE_FUNCTION, $function)

src/Instrumentation/Symfony/tests/Integration/HttpClientInstrumentationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ public function test_send_request(string $method, string $uri, int $statusCode,
4848
$this->assertNotNull($requestHeaders['HTTP_TRACEPARENT']);
4949
}
5050

51+
$this->assertTrue($span->getAttributes()->has(TraceAttributes::PEER_SERVICE));
52+
$this->assertSame(parse_url($uri)['host'] ?? null, $span->getAttributes()->get(TraceAttributes::PEER_SERVICE));
5153
$this->assertTrue($span->getAttributes()->has(TraceAttributes::URL_FULL));
5254
$this->assertSame($uri, $span->getAttributes()->get(TraceAttributes::URL_FULL));
5355
$this->assertTrue($span->getAttributes()->has(TraceAttributes::HTTP_REQUEST_METHOD));

0 commit comments

Comments
 (0)