Replies: 1 comment
-
I agree that the rule triggers too many FP, that will be improved. This rule also doesn't have a dedicated preprocessor directive to skip issues, that will be added. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I have few code samples which I think are good and maybe there could be improved SonarQube rule to handle them:
1)
2)
3)
And have question what would be best practice for this case:
I not like suggestion to name variable to "uncaught" while it is against naming convention.
And that "core" class for handle AppServer connections has no logger support and has no big sense to introduce it there.
Disconnect by my opinion should be silent, while it happens after action on AppServer were done and throwing an error may create bad situation. NO-ERROR option as well may overwrite original error with disconnect error.
Beta Was this translation helpful? Give feedback.
All reactions