Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor maven pom detection system #287

Closed
Riduidel opened this issue Nov 7, 2022 · 1 comment
Closed

Refactor maven pom detection system #287

Riduidel opened this issue Nov 7, 2022 · 1 comment
Assignees

Comments

@Riduidel
Copy link
Owner

Riduidel commented Nov 7, 2022

MavenDetailsInfererEnhancer is way too complex.
We should split it by extracting all inner classes, and separate the pom lookup code from the dependency detection system.

Notice that the pom lookup code should be made more generic in order for order build tools to use it.

@Riduidel Riduidel self-assigned this Nov 7, 2022
@Riduidel
Copy link
Owner Author

In fact, beside splitting that horrendous class into multiple small oens, it could be good to separate the maven pom detection from the maven pom processing in two different enhancers, then rewrite maven pom detection to also handle other package managers. This would impact the work on #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant