-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of BigBuf_get_addr() #899
Comments
O boy, this actually means documenting how stuff works on the device side :) |
This is related to doegox/proxmark-internal#243. |
... yeah.. putting a blank t55x7 card on top of the antenna and run lf search will trigger much. a can of worms. |
Yeah, my guesstimate was the stack before was around 12K because we increased bigbuf from 40->48K. |
Not that many places left for BigBuf_get_addr() calls. This below is from the FPGA branch, but more and more have been converted into bb_malloc style.
|
That's awesome! |
to be honest, I think this bigbuf / stack connected issues was the reason for my problems with Hitag2 stuff. |
This is blocking doegox/proxmark-internal#247.
Right now, various functions are using the "address" of BigBuf as a magic variable to pass around data. Clearly this is prone to error and cannot be used with a proper allocator. So we should remove all calls to the BigBuf_get_addr() and replace them with a BigBuf_malloc() or equivalent function.
Especially, we need to find what is the required space by those functions which often declare "I'll take as much as I need and pray that I don't overflow"
The text was updated successfully, but these errors were encountered: