-
Notifications
You must be signed in to change notification settings - Fork 774
Open
Labels
DiscussiondependenciesPull requests that update a dependency filePull requests that update a dependency file
Description
We already discussed something similar to this in the past in #145 and #373.
Originally, I was on the team "no composer.lock". By that time, we only had dev-dependencies, so there wasn't really anything reproducible to lock except the dev environment.
Now, we depend on php-di, the mbstring polyfill and some PSR interfaces. There are real dependencies we have and those have their transitive dependencies and so on.
So, I'm arguing now for introducing composer.lock now. My reasons for this are:
- Reproducibility: we could fully reproduce how a past version behaves. This is currently not possible without some archeology first.
- Accurate SBOM: our SBOM export would not display "Exact versions could not be resolved for some packages" anymore.
- Dependabot workflow: getting PRs with the changelogs for our dependencies is nice. We can know if something changed, what's new and so on.
We could also try an intermediate step first: exact versions of non-dev dependencies on composer.json.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
DiscussiondependenciesPull requests that update a dependency filePull requests that update a dependency file