Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create warnings when validators throw exceptions #224

Open
andylowry opened this issue Sep 10, 2018 · 0 comments
Open

Create warnings when validators throw exceptions #224

andylowry opened this issue Sep 10, 2018 · 0 comments

Comments

@andylowry
Copy link
Contributor

In its still-being-shaken-out state, validation is more likely than it should be to throw exceptions. Rather than such cases abruptly terminating validation (and failing the overall parse in the default case of validating before the parse completes, it would be better to create a warning for the value being validated, indicating that validation did not complete successfully for that value. It doesn't mean the value is in error, or that it's not. Just that validation shouldn't be trusted for that specific value.

This is in line with the idea that false negatives are worse than false positives for a validator: It's generally better to pass an invalid model than to fail a valid model, since the latter can interrupt processing chains even on perfectly valid input.

OK, maybe at some point that should be an option :). But for now it's our preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant