Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Java modules #46

Open
vanderzee-anl-gov opened this issue Oct 19, 2021 · 1 comment
Open

Improve support for Java modules #46

vanderzee-anl-gov opened this issue Oct 19, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@vanderzee-anl-gov
Copy link

I would like to see the Repast system become a properly defined Java module with module-info.txt specifying the modules that Repast depends on and the packages that it exports.

That may be a difficult hurdle, so if it is necessary as an interim step, it may be appropriate to have Repast define an automatic module name.

Note that becoming modular would entail removing any split packages. I am not aware of many issues with split packages, but there may be some problems related to the javax.measure package, which is mostly obtained from a dependency but also has a class defined in the repast.simphony.bin_and_src.jar archive.

@vanderzee-anl-gov
Copy link
Author

I would recommend upgrading the dependency on org.geotools jars as part of this process. We found that release version 21.2 of geotools provides an automatic module name, while version 19.1 does not. This change would also entail migrating from uses of com.vividsolutions.jts.* in your API to uses of org.locationtech.jts.*, a change that came in version 20.x of geotools.

@etatara etatara self-assigned this Aug 3, 2022
@etatara etatara added the Core label Aug 3, 2022
@etatara etatara added this to the v.3.0.0 milestone Aug 3, 2022
@etatara etatara modified the milestones: v.3.0.0, v.2.11.0 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants