Avoid Julia finalizers in Rust threads (#30)

alexrenz · web-flow · commit 5e48e67b09de · 2025-01-16T13:01:21.000+01:00
Context (RelationalAI internal): https://relationalai.slack.com/archives/C01T759CHGF/p1736335890280049?thread_ts=1734628902.080789&cid=C01T759CHGF
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "object_store_ffi"
-version = "0.11.0"
+version = "0.11.1"
 edition = "2021"
 
 [[bench]]
diff --git a/src/lib.rs b/src/lib.rs
@@ -245,6 +245,7 @@ impl Request {
 extern "C" {
     fn jl_adopt_thread() -> i32;
     fn jl_gc_safe_enter() -> i32;
+    fn jl_gc_disable_finalizers_internal() -> c_void;
 }
 
 // This is used to configure all aspects of the underlying
@@ -778,6 +779,7 @@ pub extern "C" fn start(
         {
             unsafe { jl_adopt_thread() };
             unsafe { jl_gc_safe_enter() };
+            unsafe { jl_gc_disable_finalizers_internal() };
         }
     });
 

Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,7 @@ impl Request {`
`245`	`245`	`extern "C" {`
`246`	`246`	`fn jl_adopt_thread() -> i32;`
`247`	`247`	`fn jl_gc_safe_enter() -> i32;`
	`248`	`+ fn jl_gc_disable_finalizers_internal() -> c_void;`
`248`	`249`	`}`
`249`	`250`
`250`	`251`	`// This is used to configure all aspects of the underlying`
`@@ -778,6 +779,7 @@ pub extern "C" fn start(`
`778`	`779`	`{`
`779`	`780`	`unsafe { jl_adopt_thread() };`
`780`	`781`	`unsafe { jl_gc_safe_enter() };`
	`782`	`+ unsafe { jl_gc_disable_finalizers_internal() };`
`781`	`783`	`}`
`782`	`784`	`});`
`783`	`785`