replace erase() with clear() to make imported keylist deconstruction faster (#239)

DarrenJiang13 · web-flow · commit c672f448a7a3 · 2025-07-22T20:27:27.000+01:00
diff --git a/obj_gen.cpp b/obj_gen.cpp
@@ -544,10 +544,10 @@ imported_keylist::imported_keylist(const char *filename)
 
 imported_keylist::~imported_keylist()
 {
-    while (!m_keys.empty()) {
-        free(m_keys.front());
-        m_keys.erase(m_keys.begin());
+    for (unsigned int i = 0; i < m_keys.size(); i++) {
+        free(m_keys[i]);
     }
+    m_keys.clear();
 }
 
 bool imported_keylist::read_keys(void)

Original file line number	Diff line number	Diff line change
`@@ -544,10 +544,10 @@ imported_keylist::imported_keylist(const char *filename)`
`544`	`544`
`545`	`545`	`imported_keylist::~imported_keylist()`
`546`	`546`	`{`
`547`		`- while (!m_keys.empty()) {`
`548`		`- free(m_keys.front());`
`549`		`- m_keys.erase(m_keys.begin());`
	`547`	`+ for (unsigned int i = 0; i < m_keys.size(); i++) {`
	`548`	`+ free(m_keys[i]);`
`550`	`549`	`}`
	`550`	`+ m_keys.clear();`
`551`	`551`	`}`
`552`	`552`
`553`	`553`	`bool imported_keylist::read_keys(void)`