replace erase() with clear() to make imported keylist deconstruction faster

jiangyujie.jyj · jiangyujie.jyj · commit 17956d633e34 · 2023-11-03T15:05:22.000+08:00
diff --git a/obj_gen.cpp b/obj_gen.cpp
@@ -527,10 +527,9 @@ imported_keylist::imported_keylist(const char *filename)
 {
 }
 
-imported_keylist::~imported_keylist()
-{
-    for (int i = 0; i < m_keys.size(); i++) {
-        free(m_keys.front());
+imported_keylist::~imported_keylist() {
+    for (unsigned int i = 0; i < m_keys.size(); i++) {
+        free(m_keys[i]);
     }
     m_keys.clear();
 }

Original file line number	Diff line number	Diff line change
`@@ -527,10 +527,9 @@ imported_keylist::imported_keylist(const char *filename)`
`527`	`527`	`{`
`528`	`528`	`}`
`529`	`529`
`530`		`-imported_keylist::~imported_keylist()`
`531`		`-{`
`532`		`- for (int i = 0; i < m_keys.size(); i++) {`
`533`		`- free(m_keys.front());`
	`530`	`+imported_keylist::~imported_keylist() {`
	`531`	`+ for (unsigned int i = 0; i < m_keys.size(); i++) {`
	`532`	`+ free(m_keys[i]);`
`534`	`533`	`}`
`535`	`534`	`m_keys.clear();`
`536`	`535`	`}`