Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets compression support (iOS) #87

Open
NoFearJoe opened this issue Mar 22, 2021 · 5 comments
Open

Add assets compression support (iOS) #87

NoFearJoe opened this issue Mar 22, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@NoFearJoe
Copy link
Contributor

Do you plan to add assets compression support?

If no, I can do it. But there are 3 ways of implementation:

  • Add an optional property compression for icons and images in the config file and then generate Contents.json with this property in the root directory of images or illustrations (now it's called XcodeEmptyContents).
  • Add an optional property compression for icons and images in the config file and then generate Contents.json with this property for each asset.
  • Configure compression in Figma.

Which one is better?

@subdan
Copy link
Collaborator

subdan commented Mar 22, 2021

Why do you want to change assets compression?

@NoFearJoe
Copy link
Contributor Author

This will help us to reduce their size

@subdan
Copy link
Collaborator

subdan commented Mar 22, 2021

I exported large 40 illustrations and changing compression type doesn’t reduce Asset.car file size.

Compression type Asset.car size
GPU Smallest Size 4,2 MB
GPU Best Quality 9,3 MB
Basic 13,2 MB
Lossless 2,5 MB
Automatic (Default) 2,5 MB

Could you show me an example project where setting asset compression type reduces Asset.car file size?

@NoFearJoe
Copy link
Contributor Author

It's strange because I get opposite results. I can't share my assets, but can remember my results:

  • Automatic: 190Mb
  • GPU Best Quality: 117Mb
  • GPU Smallest Size: 48Mb

I have different asset formats – pdf and png.

@subdan
Copy link
Collaborator

subdan commented Mar 22, 2021

Do you plan to add assets compression support?

No, because most developers use default compression type.

Which one is better?

The first one.

@subdan subdan added the enhancement New feature or request label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants