Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate vars and tasks in rhel8-playbook-stig.yml #89

Open
davewujcik opened this issue May 24, 2022 · 0 comments
Open

Duplicate vars and tasks in rhel8-playbook-stig.yml #89

davewujcik opened this issue May 24, 2022 · 0 comments

Comments

@davewujcik
Copy link

davewujcik commented May 24, 2022

The vars section of this generated playbook is scattered with duplicate variables and values, some are duplicated 4x.

Examples:

      var_system_crypto_policy: !!str FIPS
      var_system_crypto_policy: !!str FIPS
      sshd_approved_ciphers: !!str aes256-ctr,aes192-ctr,aes128-ctr
      sshd_approved_ciphers: !!str aes256-ctr,aes192-ctr,aes128-ctr
      sshd_approved_macs: !!str hmac-sha2-512,hmac-sha2-256
      sshd_approved_macs: !!str hmac-sha2-512,hmac-sha2-256
      var_accounts_user_umask: !!str 077
      var_accounts_user_umask: !!str 077
      var_accounts_user_umask: !!str 077
      var_accounts_user_umask: !!str 077
   tasks:
    - name: Ensure aide is installed
      package:
        name: aide
        state: present
      when: ansible_virtualization_type not in ["docker", "lxc", "openvz", "podman", "container"]
      tags:
        - CCE-80844-4
        - CJIS-5.10.1.3
        - DISA-STIG-RHEL-08-010359
        - NIST-800-53-CM-6(a)
        - PCI-DSS-Req-11.5
        - enable_strategy
        - low_complexity
        - low_disruption
        - medium_severity
        - no_reboot_needed
        - package_aide_installed

    - name: Ensure aide is installed
      package:
        name: '{{ item }}'
        state: present
      with_items:
        - aide
      when: ansible_virtualization_type not in ["docker", "lxc", "openvz", "podman", "container"]
      tags:
        - CCE-85964-5
        - DISA-STIG-RHEL-08-030650
        - NIST-800-53-AU-9(3)
        - NIST-800-53-AU-9(3).1
        - aide_check_audit_tools
        - low_complexity
        - low_disruption
        - medium_severity
        - no_reboot_needed
        - restrict_strategy

This makes customization difficult as the end user must clean all of this up before running the playbook.

Thanks,

-- Dave

@davewujcik davewujcik changed the title Duplicate vars in rhel8-playbook-stig.yml Duplicate vars and tasks in rhel8-playbook-stig.yml May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant