Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Restyle form fields to match new designs #305

Open
2 tasks
magnificode opened this issue Jul 17, 2020 · 9 comments
Open
2 tasks

[Feature] Restyle form fields to match new designs #305

magnificode opened this issue Jul 17, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktober hacktoberfest Good for Hacktoberfest help wanted Extra attention is needed

Comments

@magnificode
Copy link
Member

magnificode commented Jul 17, 2020

User Story

As a user
I want to see well designed form fields with solid UX
So I can easily provide the proper information for my business

Figma: https://www.figma.com/file/Lo1ZcBOO9t4QRbX2I0PwBQ/RBB?node-id=1938%3A8027

Acceptance Criteria

  • various input field types should match the designs provided below
  • field types that do not have specific type attributes associated with them should leverage class names to target and style the input field.

Screen Shot 2020-07-17 at 11 17 40 AM

Is your feature request related to a problem? Please describe.

N/a

Describe the solution you'd like

Leveraging Chakra UI components and the InputLeftElement, form fields across the site should match these new designs.

@magnificode magnificode added the enhancement New feature or request label Jul 17, 2020
@magnificode magnificode added this to the V1 Business Architecture milestone Jul 17, 2020
@magnificode magnificode self-assigned this Jul 17, 2020
@magnificode magnificode added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 17, 2020
@tinyherocarrot
Copy link

@magnificode Hi new contributor here! I'd be happy to tackle this feature

@magnificode
Copy link
Member Author

@tinyherocarrot excellent! Thank you so much for stepping in! If you have any questions or concerns at all, please don't hesitate to reach out :)

@magnificode
Copy link
Member Author

Hey @tinyherocarrot - wanted to check in here and see if there was anything I could do to help, or if there were any questions about the task!

@tinyherocarrot
Copy link

tinyherocarrot commented Aug 15, 2020 via email

@tinyherocarrot
Copy link

tinyherocarrot commented Aug 20, 2020

@magnificode want to make sure I have the right idea before I dive into an approach.

  1. I think this change could be implemented either through through a global stylesheet, or referencing properties from /src/gatsby-plugin-chakra-ui/theme.js. Which is a more acceptable method?

  2. Can you please provide the specifications for the restyle (ie. colors and border width)? It's hard to tell in the image provided.

@juanri0s juanri0s added the hacktoberfest Good for Hacktoberfest label Sep 26, 2020
@magnificode
Copy link
Member Author

@tinyherocarrot - 100% my fault for letting this slip through the cracks. Very very sorry for such a long delay in the response here.

I don't have issue with the approach you mention in 1. above. If setting global styles for form fields makes more sense we can certainly go that route. My assumption was that we could create "Styled" components that extends Chakra UI components with our custom style. If that is an inefficient route I am all for a more streamlined approach.

As for 2, you should be able to get all of those details from the Figma link in the issue description!

If too much time has gone by, please let me know and we'll get this task into another volunteer's hands. My apologies again for the lack of communication.

@tinyherocarrot
Copy link

@magnificode likewise, sorry for letting this drag on. I've made good progress and have restyled: Input (of varying types), Select (or dropdown).

Restyling the Checkboxes and Radio components will be more challenging, because Chakra doesn't have an easy way to replace the shape shown in the "selected" case, so I will have to write custom Checkbox & Radio components.

And one more question about the input with a dropdown to the left, where can I find an example of this in the code? What's this component called, and what's the use case?

@tinyherocarrot
Copy link

Another question, should I restyle the form fields used in other places besides in src/components/Forms? Eg. the form fields in src/components/Filters?

@magnificode
Copy link
Member Author

@tinyherocarrot appreciate the response! And thanks for the progress you've made so far, it's very helpful :)

There's a couple paths we can take here. We can certainly work with what we have in Chakra, and get as close as possible, and then iterate on this in the future. I'd have no problem with that at all. The goal here is just to start getting these form elements standardized across the site. Which leads to your second question, certainly we should leverage your newly styled form fields everywhere on the site to get closer to standardizing across the site.

Otherwise, if you're inclined to create fully custom components, I will not object! However, I may suggest, for the sake of progress, leveraging what we can in Chakra, and iterating on the styles in the future.

Thank you very much again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktober hacktoberfest Good for Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants