Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to SB3 #7

Open
katjamuench opened this issue Aug 24, 2023 · 4 comments
Open

Migration to SB3 #7

katjamuench opened this issue Aug 24, 2023 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@katjamuench
Copy link

Are there plans to move this project to SB3 eventually?

@stefanbschneider
Copy link
Member

Hi @katjamuench , there are currently no plans of migrating. I only have time to respond to questions and fix minor bugs, but not for larger efforts or refactoring I am afraid.

If you or anyone else is willing to migrate, I would be happy to receive and review the PR.

@stefanbschneider stefanbschneider self-assigned this Aug 30, 2023
@stefanbschneider stefanbschneider added the question Further information is requested label Aug 30, 2023
@burnCalories
Copy link

Hi @stefanbschneider . I have completed the migration of SB3 before, and all I need to do is download some software packages and modify some code changes to complete the migration. Do you need me to publish my code or create a branch? I am willing to provide assistance.

@katjamuench
Copy link
Author

I've also migrated it by now, however, I did need to modify the setup requirements for coord-sim and common-utils, though this seems to have made no significant impact on performance.
I do have about a five percent decline in successful flows, but I assume that is because I've just tried using PPO with no parameters adjusted, since SB3 doesn't offer ACKTR.

@stefanbschneider
Copy link
Member

If you have a fork using SB3, I'd be happy to link it in the Readme!

Since @katjamuench reported that the results are a bit worse and there's no ACKTR in SB3, I'd rather keep this repo as is. It is supposed to represent the corresponding paper, where we produced all results with ACKTR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants