Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Lists rxjs version 7.8.2 which includes breaking changes #7534

Closed
JoeClacks opened this issue Feb 22, 2025 · 3 comments
Closed

NPM Lists rxjs version 7.8.2 which includes breaking changes #7534

JoeClacks opened this issue Feb 22, 2025 · 3 comments

Comments

@JoeClacks
Copy link

Describe the bug

NPM Lists rxjs version 7.8.2 which includes breaking changes to the behavior of firstValueFrom() (a new default parameter I think). I don't see that version on Github so I wanted to make sure this was an intentional release.

Expected behavior

7.8.1 => 7.8.2 doesn't break existing code, and release notes on Github.

Reproduction code

https://www.npmjs.com/package/rxjs/v/7.8.2

Reproduction URL

No response

Version

7.8.2

Environment

No response

Additional context

No response

@benlesh
Copy link
Member

benlesh commented Feb 23, 2025

Do you have an example of the code that broke between those two version?

@benlesh
Copy link
Member

benlesh commented Feb 23, 2025

Okay, I tried out both versions testing firstValueFrom in each, I couldn't replicate any breakage. The link you provided is just a link to the npm page. Not sure what I'm supposed to get from that. I did a diff between 7.8.1 and 7.8.2 and I can't see any changes to the firstValueFrom code.

I'm going to close this as I don't have enough information to address whatever is being reported here, and I'll note the only reason I tried is there are two 👍 emojis at the bottom.

Thank you for trying to report something. I just can't figure out what it is you're trying to report.

@benlesh benlesh closed this as completed Feb 23, 2025
@ilyakonrad
Copy link

ilyakonrad commented Feb 24, 2025

@benlesh I have an example.

checkStripeStatus() {
  return new Observable((observer) => {
    if (!this.organization) return
    this.stripeService.checkStripeVerificationStatus(this.organization.id).subscribe(
      (stripeRes) => {
        this.store.dispatch(new SetStripeStatus(stripeRes))
        observer.next() // <-- this breaks the build
      },
      () => {
        this.store.dispatch(new SetStripeStatus(null))
        observer.next()
      }
    )
  })
}

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants