revert: holdPositionOnRender

ReactTooltip · Oct 24, 2023 · 24b2593 · 24b2593
1 parent 211df3d
commit 24b2593
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 47 deletions.
diff --git a/src/App.tsx b/src/App.tsx
@@ -2,7 +2,7 @@
 /* eslint-disable jsx-a11y/click-events-have-key-events */
 import { TooltipController as Tooltip } from 'components/TooltipController'
 import { IPosition } from 'components/Tooltip/TooltipTypes.d'
-import React, { useMemo, useState } from 'react'
+import React, { useState } from 'react'
 import { inline, offset } from '@floating-ui/dom'
 import styles from './styles.module.css'
 
@@ -23,26 +23,6 @@ function App() {
     setAnchorId(target.id)
   }
 
-  const [which, setWhich] = useState<'1' | '2'>('1')
-  const [show, setShow] = useState(true)
-
-  const button1 = useMemo(
-    () => (
-      <button data-tooltip-id="hold" data-tooltip-content="button 1" className="anchor-button">
-        button 1
-      </button>
-    ),
-    [],
-  )
-  const button2 = useMemo(
-    () => (
-      <button data-tooltip-id="hold" data-tooltip-content="button 2" className="anchor-button">
-        button 2
-      </button>
-    ),
-    [],
-  )
-
   return (
     <main className={styles['main']}>
       <button
@@ -113,25 +93,6 @@ function App() {
           Tooltip content
         </Tooltip>
       </section>
-      <section style={{ marginTop: '100px', marginBottom: '100px' }}>
-        <div style={{ height: '21px' }}>
-          {show && <div>{which === '1' ? button1 : button2}</div>}
-        </div>
-        <Tooltip id="hold" isOpen holdPositionOnRender>
-          Hello world!
-        </Tooltip>
-        <button
-          onClick={() => {
-            setShow(false)
-            setTimeout(() => {
-              setShow(true)
-            }, 1000)
-            setWhich((w) => (w === '2' ? '1' : '2'))
-          }}
-        >
-          switch
-        </button>
-      </section>
       <div style={{ display: 'flex', gap: '12px', flexDirection: 'row' }}>
         <div>
           <div

diff --git a/src/components/Tooltip/Tooltip.tsx b/src/components/Tooltip/Tooltip.tsx
@@ -42,7 +42,6 @@ const Tooltip = ({
   content,
   contentWrapperRef,
   isOpen,
-  holdPositionOnRender,
   setIsOpen,
   activeAnchor,
   setActiveAnchor,
@@ -380,7 +379,7 @@ const Tooltip = ({
     let updateTooltipCleanup: null | (() => void) = null
     if (closeOnResize) {
       window.addEventListener('resize', handleScrollResize)
-    } else if (activeAnchor && tooltipRef.current && !holdPositionOnRender) {
+    } else if (activeAnchor && tooltipRef.current) {
       updateTooltipCleanup = autoUpdate(
         activeAnchor as HTMLElement,
         tooltipRef.current as HTMLElement,
@@ -640,7 +639,7 @@ const Tooltip = ({
 
   const canShow = !hidden && content && show && Object.keys(inlineStyles).length > 0
 
-  return rendered || (wasShowing.current && holdPositionOnRender) ? (
+  return rendered ? (
     <WrapperElement
       id={id}
       role="tooltip"

diff --git a/src/components/Tooltip/TooltipTypes.d.ts b/src/components/Tooltip/TooltipTypes.d.ts
@@ -84,7 +84,6 @@ export interface ITooltip {
   style?: CSSProperties
   position?: IPosition
   isOpen?: boolean
-  holdPositionOnRender?: boolean
   setIsOpen?: (value: boolean) => void
   afterShow?: () => void
   afterHide?: () => void

diff --git a/src/components/TooltipController/TooltipController.tsx b/src/components/TooltipController/TooltipController.tsx
@@ -45,7 +45,6 @@ const TooltipController = ({
   position,
   isOpen,
   disableStyleInjection = false,
-  holdPositionOnRender,
   border,
   opacity,
   arrowColor,
@@ -334,7 +333,6 @@ const TooltipController = ({
     style,
     position,
     isOpen,
-    holdPositionOnRender,
     border,
     opacity,
     arrowColor,

diff --git a/src/components/TooltipController/TooltipControllerTypes.d.ts b/src/components/TooltipController/TooltipControllerTypes.d.ts
@@ -61,7 +61,6 @@ export interface ITooltipController {
   position?: IPosition
   isOpen?: boolean
   disableStyleInjection?: boolean | 'core'
-  holdPositionOnRender?: boolean
   /**
    * @description see https://developer.mozilla.org/en-US/docs/Web/CSS/border.
    *