Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to set null in patch options #1947

Merged
merged 3 commits into from
Jun 24, 2024
Merged

feat: Add ability to set null in patch options #1947

merged 3 commits into from
Jun 24, 2024
+153 −276

Conversation

TheAabedKhan
Copy link
Member

@TheAabedKhan TheAabedKhan commented Jun 13, 2024 •
edited
Loading

Some screenshots
null-patch-option

@TheAabedKhan TheAabedKhan linked an issue Jun 13, 2024 that may be closed by this pull request
bug: Can't enter "null" in patch options #1704
Open
4 tasks
@validcube validcube self-requested a review June 24, 2024 14:45
validcube
validcube approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 Approved, thanks!

Compiled using Flutter 3.23.0-0.1.pre (Beta) and tested on physical devices running Android 14 (Samsung One UI 6.1 - 1st May)

Test result (🥞 Passed)

  • Application: YouTube v19.16.39 - Custom Branding
    • Null value provided to "App name" option: ✅ (Should stay "YouTube" since we don't change anything)
    • "YT ReVanced" provided to "App name" option: ✅ (The application should be "YT ReVanced" as provided)

@validcube validcube merged commit 5c68d51 into ReVanced:dev Jun 24, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
@semantic-release-bot
chore(release): 1.21.0-dev.4 [skip ci]
a99406f 
# [1.21.0-dev.4](v1.21.0-dev.3...v1.21.0-dev.4) (2024-06-24)

### Bug Fixes

* Cache external API calls  ([#1911](#1911)) ([2c3e2e6](2c3e2e6))
* Follow language update immediately ([#1944](#1944)) ([c13827e](c13827e))
* SecurityException when patching application ([#1856](#1856)) ([e0a6de2](e0a6de2))
* Update dialog shows dev version & loading gets stuck in certain circumstances ([#1792](#1792)) ([fc52560](fc52560))

### Features

* Add ability to set `null` in patch options ([#1947](#1947)) ([5c68d51](5c68d51))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validcube validcube validcube approved these changes

Assignees

@validcube validcube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Can't enter "null" in patch options
2 participants
@TheAabedKhan @validcube