Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Re] Model of thalamocortical slow-wave sleep oscillations and transitions to activated states #87

Open
Mathilde-Reynes opened this issue Aug 27, 2024 · 13 comments

Comments

@rougier
Copy link
Member

rougier commented Oct 11, 2024

Very sorry for the long delay, we'll assign an editor soon.

@rougier
Copy link
Member

rougier commented Oct 11, 2024

@benoit-girard Can you edit this submission, I think it's a perfect fit for you.

@rougier rougier self-assigned this Nov 20, 2024
@rougier
Copy link
Member

rougier commented Nov 20, 2024

I'll handle the submission.
Disclaimer: I'm in the same lab as authors.

@rougier
Copy link
Member

rougier commented Nov 20, 2024

@benoit-girard @apdavison @heplesser @vitay @mstimberg @pietromarchesi @stephanmg

Can your review this submission on "Model of thalamocortical slow-wave sleep oscillations and transitions to activated states"

@apdavison
Copy link

yes, I can review this.

@heplesser
Copy link

I can review as well.

@mstimberg
Copy link

I'd be happy to review this, too (but certainly do not mind leaving it to the two who agreed to review earlier, either) 😊

@rougier
Copy link
Member

rougier commented Nov 21, 2024

Thank you very much.@apdavison @heplesser @mstimberg.

@apdavison @heplesser (since you were first to answer) you can start the review (and if you can do it before Christmas that would be great) and feel free to ask questions if needed.
@mstimberg Thanks again, I think I've other submission waiting for reviewers.

@rougier
Copy link
Member

rougier commented Dec 19, 2024

@apdavison @heplesser Any chance to get your reviews by next Monday (before Christmas)?

@apdavison
Copy link

@rougier I'm afraid I don't think it will be possible before Christmas. I've pencilled this in for the first full week in January, I'm targeting January 10th.

@stephanmg
Copy link

@benoit-girard @apdavison @heplesser @vitay @mstimberg @pietromarchesi @stephanmg

Can your review this submission on "Model of thalamocortical slow-wave sleep oscillations and transitions to activated states"

terribly sorry, somehow this went under the radar for me, if help is still needed, happy to assist!

@heplesser
Copy link

heplesser commented Dec 20, 2024 via email

@apdavison
Copy link

I have started reviewing the submission, and I will post more complete comments soon; however, I would like here to make a preliminary suggestion which will both (i) help me finish the review and (ii) make the re-implemented model more reproducible.

I was able to run python Thalamo_cortical.py, which completes without error. The problem is that to reproduce the data for the figures, I need to uncomment certain lines in Thalamo_cortical.py and, for some figures, also in other files. It takes a lot of reading and checking code to make sure the correct lines have been uncommented and re-commented.

If the authors have time, it would be very helpful to put the commented-out lines into a dictionary, or into functions, so that all the changes are controlled by a single parameter (ideally provided on the command-line, e.g., python Thalamo_cortical.py Figure4). Similarly, saving the raw data should be controlled by another parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants