-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduction of a comparison between operant and classical conditioning of identical stimuli in tethered Drosophila #24
Comments
I'm still in the process of getting DOIs for the repository, I hope they can be provided later? |
@brembs For the review, we don't need a code DOI, that can wait for later. And it's actually easier today to get a Software Heritage ID for a GitHub repository. However, the Metadata and Code URLs you cite don't work! Update: I discovered that my GitHub superpowers allowed me to fix the two links myself. I hope you don't mind! |
Ok, not sure where the issue was. I changed one of your links and all links work for me now. Thanks a lot! |
@brembs Thanks for the submission. |
@rougier I can handle this. |
@gdetor Great, thank you. |
Hi @eroesch, could you review this work? |
Gentle reminder |
@apdavison @benoit-girard Could one of you review this submission? |
What would be the delay to do the review? |
It' works for me. @rougier Is a potential delay in the review process acceptable? |
Given the situation, I think we can have a delay yes (like my late answer). Can we target end of June? @brembs Would that be acceptable ? |
I'm in no hurry and I have had own kid at home myself and have been late on reviews. So no pressure at all from my end. |
Ok, so @benoit-girard is being assigned as reviewer for this submission. |
I'm a bit lost, I'll need some help/clarification: the PDF URL refers to the original work, not to the pdf of the replication paper; this pdf will of course be useful, but where is the pdf of the replication paper, the ReScience one? |
Sorry, this must be my misunderstanding of the instructions! The submission is in the repository, named "article.pdf": https://github.com/brembs/DFS_reproduction |
I have updated my submission above with the direct link. |
You updated header is actually better than the template. Maybe we should adopt it as the default. |
The author documents the reproduction of data analyses using C++ code developed in the 90s. A few point need to be clarified:
|
@brembs You could use AbiWord and convert the GDoc to a .tex file. Then you can add the ReScience template packages at the preamble. Once you run a make (following the instructions on how to compile the article) the final pdf should be ready. |
I'll try that,when it is time, thanks! |
@brembs Any progress on the conversion? |
I haven't done anything, yet, as we are still waiting for @benoit-girard to let us know if the manuscript should contain additional data, or if this one figure is sufficient. Once I know that the manuscript is (near) final, I'll try the suggestions here. |
@benoit-girard Gentle reminder |
Oh sorry! The notifications of this thread got lost in the middle of all ReScience notifications... I am trying to improve my workflow so that it does not happen anymore.
I feel these figures (those that can be reproduced without effort) should then be added to the manuscript.
For the remaining figures, I would be nice to try to reproduce them, but I do not consider it as mandatory. |
@benoit-girard Thank you for the comments. |
It is easy to just run the same procedure on more figures - what worked for one figure will work for the others. I'll generate new figures for them. I'll also have a look and see if I can get one other figure reproduced that isn't part of the same workflow, but I can't promise I will be able to get it done. All of this will take some time, but I don't know how much. I'm pretty much at capacity right now, so it will have to wait until I got some items off of my to-do list. |
Hi @brembs any progress on this matter? |
It was looking good for a while late October, then manuscripts and theses needed revising and reviewing. Apparently, everybody also submits their manuscripts before the holidays, so I'm inundated with reviews and such. No chance I can get it done this year, sorry. |
@gdetor Any progress? |
Hi @brembs Do you think we could finalize the process? |
I've been trying, but still swamped. Hope to get it done before the summer holidays, which start in August here. No more teaching until then, so the chances look good. |
Hi @brembs Thank you for the update. |
@brembs Gentle reminder |
I have been thinking that there was something last summer that I forgot to do :-) |
Yes, yes :-) |
@brembs Happy new year. Gentle reminder |
Thank you and happy new year to you, too! It is on my list and I am frustrated I wasn't able to get it done before the end of the break. |
@brembs Gentle reminder |
Please believe me, I'm still trying. Difficulty lies in prioritizing this work, in part since the remaining work would only constitute a repetition of what I already showed for the first dataset. |
Hi @brembs any updates? |
It's still on my list, but new things keep coming up. Once there is an opening, I'll finish it. Just don't know when this will be. |
@brembs Can we consider closing this issue or do you intend to work on it? We'll soon hit the 1000 days target since submision :) |
I've always intended to work on it, but given what other projects I have, it seems like too much work for a very small improvement on the manuscript. Working on the text is not an issue, but if the example I showed is not sufficient to show that I could in principle do the same thing with the rest of the data, then I'm afraid I must pass, sorry. |
What is blocking actually ? If this is he conversion to ReScience template, I can take care of that if you want. |
No, IIRC, the reviewers felt that taking one dataset as an example was not sufficient, I needed to take the other, analogous datasets that made up the other figures in the original publication and generate the other figures as well. It's essentially doing the exact same pipeline I did for the first version and repeat that pipeline for the other figures. It's not completely unreasonable, but it adds nothing other than volume to the paper, IMHO. It makes the paper more 'complete' in that I haven't reproduced just a single figure of the original article,but the majority of figures. |
Ok. We can leave the submission open just in case you find some spare time in the coming weeks. |
Original article:
Brembs B and Heisenberg M (2000): The Operant and the Classical in Conditioned Orientation of Drosophila melanogaster at the Flight Simulator. Learn Mem. 7(2): 104–115. doi: 10.1101/lm.7.2.104
PDF URL original article:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC311324/pdf/x2.pdf
PDF URL submitted article:
https://github.com/brembs/DFS_reproduction/blob/master/article.pdf
Metadata URL:
https://github.com/brembs/DFS_reproduction/blob/master/DFSreproduction.yaml
Code URL:
https://github.com/brembs/DFS_reproduction/tree/master/evaluation_code
Scientific domain:
Neurobiology
Programming language:
Turbo Pascal, R, C++
Suggested editor:
The text was updated successfully, but these errors were encountered: