Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tag groups using "::" delimiter #205

Merged
merged 1 commit into from
Aug 24, 2024
Merged

feat: Add tag groups using "::" delimiter #205

merged 1 commit into from
Aug 24, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Jul 19, 2024

@Razeeman
Copy link
Owner

Interesting idea. Couple of points come to mind. Need to check that tags like "tagName::" or "::tagName" does not create some weird empty groups. Also some new UI tests for this feature would be great.

@cogk cogk changed the title [WIP] feat: Add tag groups using "::" delimiter feat: Add tag groups using "::" delimiter Aug 11, 2024
@cogk
Copy link
Contributor Author

cogk commented Aug 21, 2024

Okay I think I'm not good enough yet to write the UI tests for this feature haha

@cogk
Copy link
Contributor Author

cogk commented Aug 21, 2024

@cogk cogk marked this pull request as ready for review August 21, 2024 19:19
@Razeeman
Copy link
Owner

Razeeman commented Aug 21, 2024 •
edited
Loading

Understand, that's ok, will add tests later after the merge.

@Razeeman Razeeman merged commit 2cc8d2b into Razeeman:dev Aug 24, 2024
1 of 4 checks passed
@Razeeman
Copy link
Owner

Thank you!

@alkero
Copy link

alkero commented Aug 27, 2024

Hi,
Interesting functionality.
Is this supposed to be in the 1.45 version? Because it doesn't seem to work for me.
(not sure if it's the proper place to discuss this by the way...).

Thanks.

@cogk
Copy link
Contributor Author

cogk commented Aug 27, 2024 •
edited
Loading

Hi, Interesting functionality. Is this supposed to be in the 1.45 version? Because it doesn't seem to work for me.

Hey @alkero, the feacture has not been released yet, but it will probably be available in the next version.

https://github.com/Razeeman/Android-SimpleTimeTracker/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razeeman Razeeman Razeeman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cogk @Razeeman @alkero