Adds additional validators and "write_script" routine #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPaulSharp
commented
Oct 17, 2023
StephenNneji
approved these changes
Oct 18, 2023
tests/test_project.py
Outdated
| ]) | ||
| def test_write_script(test_project, test_project_script, input_filename: str) -> None: | ||
| """Test the script we write to regenerate the project is created and runs as expected.""" | ||
| path = tempfile.mkdtemp(dir='.') |
There was a problem hiding this comment.
I don't think the dir is necessary as this will create the test folder in my repo folder which will not be deleted if the test failed, without dir it should be created in the user's tmp directory. Also it will be better to setup shutil.rmtree in a teardown function
There was a problem hiding this comment.
Ok, now done. Although avoiding all of this was why I had a mock file in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.