Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with carthage integration #35

Open
Nainculte opened this issue Jun 4, 2019 · 3 comments
Open

Issue with carthage integration #35

Nainculte opened this issue Jun 4, 2019 · 3 comments

Comments

@Nainculte
Copy link

Hello I am getting multiple issues with the carthage integration of this project in my app when submitting the app to the AppStore as follows:

App Store Connect Operation Error
CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'MyApp.app'.
App Store Connect Operation Error
Invalid Bundle. The bundle at 'MyApp.app/Frameworks/Slider.framework' contains disallowed nested bundles.
App Store Connect Operation Error
Invalid Bundle. The bundle at 'MyApp.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.

I am copying the frameworks using the carthage utilities. So I am wondering what I am doing wrong here. If I don't copy them it just doesn't work.

I am using Xcode 10.2 and Carthage 0.33.0

@Drusy
Copy link

Drusy commented Jul 4, 2019

Hello @Nainculte, I am having the same issue, did you find a fix?

"Error Domain=ITunesTransporterErrorDomain Code=-18000 \"ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\"\" UserInfo={NSLocalizedRecoverySuggestion=ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\", NSLocalizedDescription=ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\", NSLocalizedFailureReason=ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\"}"
"Error Domain=ITunesTransporterErrorDomain Code=-18000 \"ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\"\" UserInfo={NSLocalizedRecoverySuggestion=ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\", NSLocalizedDescription=ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\", NSLocalizedFailureReason=ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\"}"
"Error Domain=ITunesTransporterErrorDomain Code=-18000 \"ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\"\" UserInfo={NSLocalizedRecoverySuggestion=ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\", NSLocalizedDescription=ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\", NSLocalizedFailureReason=ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\"}"

Any idea @RamotionDev ? Are you using Carthage to publish your own demo app including this Slider ?

@Drusy
Copy link

Drusy commented Jul 4, 2019

A Script Phase rm -r ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Slider.framework/Frameworks right after the Carthage copy frameworks phase pass the AppStoreConnect validation.

This is only a workaround and would be nice to be fixed in the next release

@kenji21
Copy link

kenji21 commented Jul 4, 2019

The carthage copy-framework isn't necessary for framework target, the will have both your dependency and your framework in Carthage/Build directory:

ls -1 Carthage/Build/iOS/ |grep -E "pop|Slider"
Slider.framework
Slider.framework.dSYM
pop.framework
pop.framework.dSYM

The application will have to copy both framework in their run script build phase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants