Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip slide-scroll animation between home screen and soldering screen if detailed view is enabled for both modes in the settings #2076

Closed
Siutas opened this issue Feb 14, 2025 · 10 comments · Fixed by #2102
Assignees
Labels
Bug Serious issue or problem. Enhancement New feature or additional function. Usability UX, Usability and/or Design.

Comments

@Siutas
Copy link

Siutas commented Feb 14, 2025

Scroll animation should be removed if both idle and operating detailed screens are used

@Ralim
Copy link
Owner

Ralim commented Feb 15, 2025

Hello,

Can you please provide more detail on this request, do you not want the settings scroll animation or the sliding transition between screens?

@ia
Copy link
Collaborator

ia commented Feb 15, 2025

Scroll animation should be removed if both idle and operating detailed screens are used

Hello, @Siutas.

I'm happily do use IronOS with Soldering detailed screen & Idle detailed screen options enabled always all the time, and I do not have any issues with scroll animation at all.

So, could you, please, describe what is the issue exactly? Thanks.

@ia ia added the Awaiting Response Waiting for user response, if none issue will be closed. label Feb 15, 2025
@discip
Copy link
Collaborator

discip commented Feb 25, 2025

@Siutas
I see your point.
If I'm not mistaken, that's exactly what I initially wasn't fond of either.
Eventually I got used to it, but now that you mentioned it, my memories have been revived.
I also liked activating or stopping the heating without the sliding transition more, while both the idle- and the soldering screen were set to detailed.

@Ralim
Copy link
Owner

Ralim commented Feb 28, 2025

I think this is the transitions rather than the scroll animation (in settings).
We could add a settings option to just disable these fairly easily.

@ia ia self-assigned this Mar 3, 2025
@ia ia added Usability UX, Usability and/or Design. and removed Awaiting Response Waiting for user response, if none issue will be closed. labels Mar 3, 2025
@ia ia changed the title Scroll animation Add option to disable side-scroll animation effect for switching modes Mar 3, 2025
@ia
Copy link
Collaborator

ia commented Mar 4, 2025

Dear friends, it seems I got a working prototype. I just will have to add a setting routine and double check everything, but "I take this case". ;)

@discip, out of curiosity:

If I'm not mistaken, that's exactly what I initially wasn't fond of either.
Eventually I got used to it, but now that you mentioned it, my memories have been revived.
I also liked activating or stopping the heating without the sliding transition more, while both the idle- and the soldering screen were set to detailed.

But what's wrong with the slide transition animation for you? Just asking, because although it really looks pretty cool and fancy, I think I tend to agree that in some cases it's a bit more distracting from the process of getting information on the display, than entertaining.

And what's your "rationale", so to speak? Just would like to hear. :)

@ia ia assigned discip Mar 5, 2025
@ia
Copy link
Collaborator

ia commented Mar 5, 2025

@discip, while you seem interested in this option as well, could you, please, try and test something from these builds.

I added a new checkbox option Anim.sliding in User interface submenu. I tested it briefly. It seems like it's doing exactly what you & @Siutas were talking about. Except... it works too good: even smooth scrolling animation inside settings menu (between menu items) is disabled, once this option is disabled as well.

Now, could you tell me, please, how do you think - is this expected behavior (I mean, we disable slide-side-scroll animation, right?)? Or should be there some exceptions, and if yes, then for which situations/modes?

Just let me know, what you think, because I can't wait to hear any feedback.

@Ralim
Copy link
Owner

Ralim commented Mar 5, 2025

We could expand it to a Transition setting of "All, Only Vertical, Only Horizontal, None" ? to give users the choice

@discip
Copy link
Collaborator

discip commented Mar 5, 2025

I'm currently unable to spend time on this (work), but will let you know as soon as possible.

@ia
Copy link
Collaborator

ia commented Mar 5, 2025

We could expand it to a Transition setting of "All, Only Vertical, Only Horizontal, None" ? to give users the choice

I just love boolean-like checkbox options since they are sooo easy to implement, maintain & support. But if we have to do multiple choice here, then I think that something like "fully off, on modes change only, in settings only, fully on" sounds more reasonable than a specific effect, wouldn't you agree?

What is the exact reason to disable a particular animation effect regardless the mode, while some users may would like to have animation scrolling in settings, but not between modes and vice versa. I can say it from my perspective: I tested my patch, and I must admit, that without full animation the response from the iron subjectively (for obvious reasons) looks way much more faster, but not having animation on scrolling settings gives a subjective feeling like something is wrong.

@discip, I don't rush you at all, so only when you have time, but, please, try to test my builds first, and then let me know what you think and how do you think we should proceed, since you're interested in this option. Thanks.

@ia
Copy link
Collaborator

ia commented Mar 5, 2025

@Siutas, are you still interested in this option? Just asking.

@ia ia linked a pull request Mar 6, 2025 that will close this issue
2 tasks
@ia ia added Enhancement New feature or additional function. Bug Serious issue or problem. labels Mar 7, 2025
@ia ia changed the title Add option to disable side-scroll animation effect for switching modes Skip slide-scroll animation between home screen and soldering screen if detailed view is enabled for both modes in the settings Mar 7, 2025
ia added a commit to ia/IronOSf that referenced this issue Mar 7, 2025
ia added a commit that referenced this issue Mar 9, 2025
Disable animation between home and soldering screens if detailed view is set for both modes (probably a finally proper fix for #2076)
@ia ia closed this as completed in #2102 Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Serious issue or problem. Enhancement New feature or additional function. Usability UX, Usability and/or Design.
Projects
None yet
4 participants