Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize item container #93

Open
Filipsi opened this issue May 18, 2023 · 3 comments
Open

Ability to customize item container #93

Filipsi opened this issue May 18, 2023 · 3 comments

Comments

@Filipsi
Copy link

Filipsi commented May 18, 2023

Is there a better way to remove rounded corners from selected item container other then overriding entire control template?
Would it be possible to add something like ItemContainerTemplate or ItemContainerStyle so it could be customized easier?

@sdolhaor
Copy link
Contributor

I've added a new SelectedItemContainerCornerRadius at MultiSelectComboBox component level - this should help customizing the control without redefining the container's template: PR #94.

@Filipsi
Copy link
Author

Filipsi commented May 19, 2023

Thank you for a quick response and subsequent pull request.

I have one more thing, regarding item container customization.
When the control is in edit mode, the selected item has a remove button with a "Remove" tool-tip.
I would like to localize this text for my use case, which is currently only possible by overriding entire control template.

@sdolhaor
Copy link
Contributor

Thanks for the follow-up. I think we'll need to check if other texts need properties as well, i.e. also in any other places not only on remove button (to avoid the need of templating just for setting their values)...
When I'll have time I'll do some further analysis on it myself. If you, however, have time sooner, you can also try it in a fork and submit a PR with changes; we'll surely review it and merge it if everything is fine!

@sdolhaor sdolhaor closed this as completed Jul 7, 2023
@sdolhaor sdolhaor reopened this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants