Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default configurations and attributes #333

Open
mgdenno opened this issue Nov 19, 2024 · 3 comments
Open

Remove the default configurations and attributes #333

mgdenno opened this issue Nov 19, 2024 · 3 comments
Milestone

Comments

@mgdenno
Copy link
Contributor

mgdenno commented Nov 19, 2024

I think we should consider removing the default configurations and attributes from the template. I think it just makes it messy. Might be more useful if we knew that each value in say configurations was actually used.

@mgdenno
Copy link
Contributor Author

mgdenno commented Nov 19, 2024

@samlamont what say you?

@samlamont
Copy link
Collaborator

Sounds good to me, I agree it's messy and potentially confusing for the user. How about the units and variables tables as well? That way everything in the dataset is actually being used by a particular evaluation. Maybe we could automatically load domain values if they are members of hard-coded enums otherwise require the user to add manually?

I was also thinking about creating another level of sub-directories in the dataset, in an attempt to provide more clarity for the user. Something like:

  • timeseries
    • primary
    • secondary
    • joined
  • domains
    • units
    • variables
    • configurations
    • attributes
  • spatial/locations
    • locations
    • locations crosswalks

Maybe this just adds unnecessary complexity?

@mgdenno
Copy link
Contributor Author

mgdenno commented Nov 19, 2024

I think units and variables, esp. units are a but more complicated. Since we ultimately want to move towards automatic unit conversions i think we need consistency there...

@mgdenno mgdenno modified the milestones: v0.4 Release, v0.5 Release Nov 19, 2024
@mgdenno mgdenno changed the title Consider removing all the default configurations and attributes Remove the default configurations and attributes Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants