You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of the setter functions are not asynchronous. This is not desirable because we often have use cases for using asynchronous code (ie: fetch requests) within beforeSet/afterSet functions as well as loadData itself.
Make setFilter async
Make loadData async
Make setChartData async
Ensure that all of the above wait on their respective before/after set functions
The text was updated successfully, but these errors were encountered:
After realizing that making certain function async would not allow us to await a subscription relative to the trigger we decided to go with a different approach. Alex specified:
what if HVB just ran setFilter, and harness itself had the check for synchronous and running of loadData? if so, we formalize the synchronous behavior instead of having that be a side effect of the component package. and if we do, we can put that check into the subscription block so that it explicitly runs after user-defined afterSet behaviors
Most of the setter functions are not asynchronous. This is not desirable because we often have use cases for using asynchronous code (ie: fetch requests) within beforeSet/afterSet functions as well as loadData itself.
setFilter
asyncloadData
asyncsetChartData
asyncThe text was updated successfully, but these errors were encountered: