refactor: translation language -> action language (#3154)

* refactor: action language -> action language

* type

* mobile

* type

* fix

* prefer local settings, drop backward compatibility

* update

* update

* update

* chore: auto-fix linting and formatting issues

* update

* update

* update

* follow ui

* update

* add description

* fix build

* update

* update

* update

Author: hyoban

apps/desktop/locales/settings/en.json

@@ -187,7 +187,9 @@
   "general.startup_screen.timeline": "Timeline",
   "general.startup_screen.title": "Startup Screen",
   "general.timeline": "Timeline",
-  "general.translation_language": "Translation Language",
+  "general.action_language.label": "Action Language",
+  "general.action_language.default": "Default (UI Language)",
+  "general.action_language.description": "The language used for translation and summary",
   "general.unread": "Unread",
   "general.voices": "Voices",
   "integration.eagle.enable.description": "Display 'Save media to Eagle' button when available.",

apps/desktop/locales/settings/ja.json

@@ -167,7 +167,6 @@
   "general.startup_screen.timeline": "タイムライン",
   "general.startup_screen.title": "スタートアップスクリーン",
   "general.timeline": "タイムライン",
-  "general.translation_language": "翻訳する言語",
   "general.unread": "未読",
   "general.voices": "音声",
   "integration.eagle.enable.description": "利用可能な場合、'Eagle にメディアを保存' ボタンを表示します。",

apps/desktop/locales/settings/ko.json

@@ -172,7 +172,6 @@
   "general.startup_screen.timeline": "타임라인",
   "general.startup_screen.title": "시작 화면",
   "general.timeline": "타임라인",
-  "general.translation_language": "번역 언어",
   "general.unread": "읽지 않음",
   "general.voices": "음성",
   "integration.eagle.enable.description": "가능할 때 '미디어를 Eagle 에 저장' 버튼 표시.",

apps/desktop/locales/settings/zh-CN.json

@@ -187,7 +187,6 @@
   "general.startup_screen.timeline": "时间线",
   "general.startup_screen.title": "起始界面",
   "general.timeline": "时间线",
-  "general.translation_language": "翻译语言",
   "general.unread": "未读",
   "general.voices": "声音",
   "integration.eagle.enable.description": "显示「保存到 Eagle」按钮（如果可用）。",

apps/desktop/locales/settings/zh-HK.json

@@ -187,7 +187,6 @@
   "general.startup_screen.timeline": "時間軸",
   "general.startup_screen.title": "啟動畫面",
   "general.timeline": "時間軸",
-  "general.translation_language": "翻譯語言",
   "general.unread": "未讀",
   "general.voices": "語音",
   "integration.eagle.enable.description": "顯示「將媒體儲存到 Eagle」按鈕（如果可用）",

apps/desktop/locales/settings/zh-TW.json

@@ -172,7 +172,6 @@
   "general.startup_screen.timeline": "時間軸",
   "general.startup_screen.title": "開始畫面",
   "general.timeline": "時間軸",
-  "general.translation_language": "翻譯語言",
   "general.unread": "未讀",
   "general.voices": "聲音",
   "integration.eagle.enable.description": "顯示「將媒體儲存到 Eagle」按鈕（如果可用）。",

apps/desktop/src/renderer/src/atoms/settings/general.ts

@@ -1,13 +1,16 @@
 import { createSettingAtom } from "@follow/atoms/helper/setting.js"
+import type { SupportedLanguages } from "@follow/models"
 import type { GeneralSettings } from "@follow/shared/interface/settings"
 
 import { jotaiStore } from "~/lib/jotai"
 
+export const DEFAULT_ACTION_LANGUAGE = "default"
+
 const createDefaultSettings = (): GeneralSettings => ({
   // App
   appLaunchOnStartup: false,
   language: "en",
-  translationLanguage: "zh-CN",
+  actionLanguage: DEFAULT_ACTION_LANGUAGE,
 
   // mobile app
   startupScreen: "timeline",
@@ -47,6 +50,14 @@ export const {
   settingAtom: __generalSettingAtom,
 } = createSettingAtom("general", createDefaultSettings)
 
+export function useActionLanguage() {
+  const actionLanguage = useGeneralSettingSelector((s) => s.actionLanguage)
+  const language = useGeneralSettingSelector((s) => s.language)
+  return (
+    actionLanguage === DEFAULT_ACTION_LANGUAGE ? language : actionLanguage
+  ) as SupportedLanguages
+}
+
 export const subscribeShouldUseIndexedDB = (callback: (value: boolean) => void) =>
   jotaiStore.sub(__generalSettingAtom, () => callback(getGeneralSettings().dataPersist))
 

apps/desktop/src/renderer/src/lib/immersive-translate.ts

@@ -36,11 +36,9 @@ export function immersiveTranslate({
     return
   }
 
-  const translation = entry.settings?.translation ?? targetLanguage
-
   const immersiveTranslateMark = html.querySelectorAll("[data-immersive-translate-mark=true]")
   if (immersiveTranslateMark.length > 0) {
-    if (translation) {
+    if (targetLanguage) {
       return
     }
 
@@ -49,7 +47,7 @@ export function immersiveTranslate({
     }
   }
 
-  if (!translation) {
+  if (!targetLanguage) {
     return
   }
 
@@ -61,7 +59,7 @@ export function immersiveTranslate({
 
     translate({
       entry,
-      language: translation,
+      language: targetLanguage,
       part: textNode.textContent,
       extraFields: ["content"],
     }).then((transformed) => {
@@ -96,7 +94,7 @@ export function immersiveTranslate({
     if (tag.textContent) {
       const isLanguageMatch = checkLanguage({
         content: tag.textContent,
-        language: translation,
+        language: targetLanguage,
       })
       if (isLanguageMatch) {
         continue
@@ -151,7 +149,7 @@ export function immersiveTranslate({
 
         translate({
           entry,
-          language: translation,
+          language: targetLanguage,
           part: textContent,
           extraFields: ["content"],
         }).then((transformed) => {

apps/desktop/src/renderer/src/lib/translate.ts

@@ -1,42 +1,13 @@
 import { parseHtml } from "@follow/components/ui/markdown/parse-html.js"
 import { views } from "@follow/constants"
 import type { SupportedLanguages } from "@follow/models/types"
+import { LANGUAGE_MAP } from "@follow/shared"
 import { franc } from "franc-min"
 
 import type { FlatEntryModel } from "~/store/entry"
 
 import { apiClient } from "./api-fetch"
 
-export const LanguageMap: Record<
-  SupportedLanguages,
-  {
-    label: string
-    value: string
-    code: string
-  }
-> = {
-  en: {
-    value: "en",
-    label: "English",
-    code: "eng",
-  },
-  ja: {
-    value: "ja",
-    label: "Japanese",
-    code: "jpn",
-  },
-  "zh-CN": {
-    value: "zh-CN",
-    label: "Simplified Chinese",
-    code: "cmn",
-  },
-  "zh-TW": {
-    value: "zh-TW",
-    label: "Traditional Chinese (Taiwan)",
-    code: "cmn",
-  },
-}
-
 export const checkLanguage = ({
   content,
   language,
@@ -48,10 +19,12 @@ export const checkLanguage = ({
   const pureContent = parseHtml(content)
     .toText()
     .replaceAll(/https?:\/\/\S+|www\.\S+/g, " ")
+  const { code } = LANGUAGE_MAP[language]
+  if (!code) return false
   const sourceLanguage = franc(pureContent, {
-    only: [LanguageMap[language].code],
+    only: [code],
   })
-  if (sourceLanguage === LanguageMap[language].code) {
+  if (sourceLanguage === code) {
     return true
   } else {
     return false

apps/desktop/src/renderer/src/modules/action/target-action-list.tsx

@@ -1,7 +1,6 @@
 import { ActionButton, Button } from "@follow/components/ui/button/index.js"
 import { Divider } from "@follow/components/ui/divider/index.js"
 import { Input } from "@follow/components/ui/input/index.js"
-import { ResponsiveSelect } from "@follow/components/ui/select/responsive.js"
 import {
   Table,
   TableBody,
@@ -10,7 +9,7 @@ import {
   TableHeader,
   TableRow,
 } from "@follow/components/ui/table/index.jsx"
-import type { ActionModel, SupportedLanguages } from "@follow/models/types"
+import type { ActionModel } from "@follow/models/types"
 import { Fragment, useMemo } from "react"
 import { useTranslation } from "react-i18next"
 
@@ -31,28 +30,6 @@ type Action = {
   onRemove: (data: ActionModel) => void
 }
 
-const TransitionOptions: {
-  label: string
-  value: SupportedLanguages
-}[] = [
-  {
-    label: "English",
-    value: "en",
-  },
-  {
-    label: "日本語",
-    value: "ja",
-  },
-  {
-    label: "简体中文",
-    value: "zh-CN",
-  },
-  {
-    label: "繁體中文",
-    value: "zh-TW",
-  },
-]
-
 const AddTableRow = ({ onClick, disabled }: { onClick?: () => void; disabled?: boolean }) => {
   const { t } = useTranslation("settings")
   return (
@@ -108,26 +85,11 @@ export const TargetActionList = ({ index }: { index: number }) => {
         title: t("actions.action_card.translate_into"),
         enabled: !!translation,
         onInit: (data) => {
-          data.result.translation = "zh-CN"
+          data.result.translation = true
         },
         onRemove: (data) => {
           delete data.result.translation
         },
-        config: () => (
-          <ResponsiveSelect
-            disabled={disabled}
-            size="sm"
-            value={translation}
-            onValueChange={(value) => {
-              onChange((data) => {
-                data.result.translation = value
-              })
-            }}
-            items={TransitionOptions}
-            triggerClassName="w-fit max-w-44 text-sm"
-          />
-        ),
-        configInline: true,
       },
       {
         title: t("actions.action_card.enable_readability"),