Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store item id selected before item disappears from shop stock during sell-x dialogue #69

Open
Hubcapp opened this issue Jan 17, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Hubcapp
Copy link
Member

Hubcapp commented Jan 17, 2021

We could store the reference to item ID selected when the Sell-X dialogue box is summoned, then just always use that last-selected-item when the packet is sent. This way the user would not have their input discarded.

Related to authentic bug #64, fixed in PR #68.

@Hubcapp Hubcapp added the enhancement New feature or request label Jan 17, 2021
@lmsv-mx123
Copy link
Member

For reference on anyone taking look into enhancement, also should be considered case for Buy-x

@Hubcapp
Copy link
Member Author

Hubcapp commented Jan 17, 2021

Technically Buy-X might be possible to trigger, but the setup for that is much rarer.

  1. has to be an item that store doesn't have any base stock of, because otherwise the index won't disappear, the shop just says "has 0"
  2. player starts buying "x" of item they would not normally expect in the store
  3. all stock is depleted!
  4. stock is replenished by a second player in time for the buy-x to make sense again (if step 4 doesn't happen, then current behaviour is fine, because it just exits gracefully)
  5. send the buy-x with the last selected item id

Set up for sell-x:

  1. sell a few of an item to shop that they don't normally stock
  2. realize you actually need to sell quite a few, sell-X
  3. shop despawns quick & the item id gets set to -1
  4. send the sell-x with the last selected item id

@Hubcapp Hubcapp changed the title Search for new shop index when item disappears from shop stock during sell-x dialogue Store item id selected before item disappears from shop stock during sell-x dialogue Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants