Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP Overlay sometimes displays HP info from two separate NPCs #61

Open
ChildOfDreams opened this issue Dec 12, 2020 · 2 comments
Open

HP Overlay sometimes displays HP info from two separate NPCs #61

ChildOfDreams opened this issue Dec 12, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@ChildOfDreams
Copy link
Contributor

Sometimes, after either combatant has fled from a battle or you have killed an NPC, a second HP overlay bar will display during/when engaging combat with a new NPC (of the same type?). The HP bars will swap intermittently between themselves which causes a flickering effect. This typically clears up once combat has ended again, though it can sometimes persist for a few battles, which can cause even more HP overlays to display (as seen below).

Screenshot from 2020-12-11 16 05 42

@Hubcapp Hubcapp added the bug Something isn't working label Dec 12, 2020
@Hubcapp
Copy link
Member

Hubcapp commented Dec 12, 2020

Honestly not even sure why this would be possible. Is there some loop on purpose for drawing additional bars? Was this an original design feature? Probably not since it flickers every frame. Will need to introduce an "active npc" concept to the client. Alternatively could let the user tag as many npcs as they want manually, but, seems like a lot of work for no reason.

@lmsv-mx123
Copy link
Member

I think could be a failure to detect the active npc they are fighting against. @nickzuber had tried to get the active npc but is not perfect. He hadn't meant to have shown nearby ones, just probably in case like the image, where the first mobs bar was likely not the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants