Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hex code for colors #86

Open
mikev-cw opened this issue May 4, 2023 · 1 comment
Open

hex code for colors #86

mikev-cw opened this issue May 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mikev-cw
Copy link
Collaborator

mikev-cw commented May 4, 2023

I noticed that color is an integers used as the index for a list of default colors. Wouldn't it be better to save the HEX code instead and convert it directly to the Color class? With the current solution, if we were to edit the list of colors, we'd have to change all indexes across the database.

(From a comment of @GBergatto on #85)

@theperu theperu added the enhancement New feature or request label May 10, 2023
@lucaantonelli
Copy link
Collaborator

I would agree, but now that we also have dark mode maybe it's easier to manage both types of colors with int, choosing the list based on the theme. I don't know if there could be a better solution for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants