Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new metrics: standard deviation and median of gradient #19

Open
PinkShnack opened this issue Nov 22, 2022 · 1 comment
Open

Add new metrics: standard deviation and median of gradient #19

PinkShnack opened this issue Nov 22, 2022 · 1 comment

Comments

@PinkShnack
Copy link
Collaborator

PinkShnack commented Nov 22, 2022 •
edited
Loading

Kyoo was working on a std metric and it seems to work well for certain samples (beads). I have implemented these in a branch of nrefocus on my fork. I could create a merge request if it is something that would enhance nrefous.

To do:

  • Add std and med metrics
  • Test new metrics (and check if old ones need more tests)
  • Add an example showing a comparison for the example cell image.
@paulmueller
Copy link
Member

Definitely 👍 💪

@PinkShnack PinkShnack mentioned this issue Dec 12, 2022
Merged
5 tasks
paulmueller added a commit that referenced this issue Jan 9, 2023
@PinkShnack @paulmueller
Add standard deviation and median gradient metrics (#20, #19)
f20a8dd 
* feat: standard deviation metric added

* tests, example: add tests and examples for metric comparison

* tests, docs: correct dcstrings for tests

* docs: include a metric comparison example in the docs


Co-authored-by: Eoghan O'Connell <[email protected]>
Co-authored-by: Paul Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmueller @PinkShnack