You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In most of my cases, if I am calling the Refocus.autofocus method, I am using the same value for the roi argument.
Therefore, every time I call this method, the roi checks are being performed even though they don't need to be.
Possible Solutions
Implement roi as a Refocus class attribute, which will be checked once when instantiating the class or anytime a Refocus.parse_roi() method is called (in the case that users want to change the roi each Refocus.autofocus call). See #16 and #17.
Notes
The Refocus.autofocusroi argument could be deprecated or left as is for convenience.
I would say this issue is low priority, because the speed gains are likely small.
To do:
Implement roi as a Refocus class attribute
Refactor the roi docstring a little bit so that it displays nicely with sphinx (use bullet points, similar to the metric docstring param description.
The text was updated successfully, but these errors were encountered:
Problem
In most of my cases, if I am calling the
Refocus.autofocus
method, I am using the same value for theroi
argument.Therefore, every time I call this method, the roi checks are being performed even though they don't need to be.
Possible Solutions
Implement
roi
as aRefocus
class attribute, which will be checked once when instantiating the class or anytime aRefocus.parse_roi()
method is called (in the case that users want to change theroi
eachRefocus.autofocus
call). See #16 and #17.Notes
The
Refocus.autofocus
roi
argument could be deprecated or left as is for convenience.I would say this issue is low priority, because the speed gains are likely small.
To do:
roi
as aRefocus
class attributemetric
docstring param description.The text was updated successfully, but these errors were encountered: