Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Report Handling to the Restore Option #47

Open
darnjo opened this issue May 4, 2023 · 0 comments
Open

Add Error Report Handling to the Restore Option #47

darnjo opened this issue May 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@darnjo
Copy link
Member

darnjo commented May 4, 2023

Currently, if there are errors in one of the results directories from the runDDTests option, the files are skipped.

With the ETL process, we can now ingest the errors as well and produce a Failed report.

The restore option should be adjusted to detect when there are errors, and then pick up the relevant files and post them as Failed tests.

There are a few cases here:

  • All required files are present but there was an error. Usually there will be an error.log in this scenario. In general, if there's an error.log then there was an error, even if it's 0 length.
  • Not all required files are present, but there's still an error.log file. In this scenario, the utils need to figure out which required files weren't there and detect what failed, then create a request to handle this accordingly.
  • Not all required files are present, but there's no error.log file. In this case, the error step can be determined by detecting which required files are not present.

Cert Utils skips the error scenario and logs it in the terminal presently:

Missing Results Files: 3
         * tmp/T000000XX-5XXXX/M00000XXX/current
         * tmp/T000000XX-5XXXX/M00000XXX/current
         * tmp/T000000XX-5XXXX/M00000XXX/current

It also provides the reason for the error usually.

This should be a library method that can be called from the Certification backend as well as the Cert Utils CLI.

@darnjo darnjo added the enhancement New feature or request label May 4, 2023
@darnjo darnjo added this to the Backlog milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants