Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Item Hold Positions #1348

Open
cosmiccoincidence opened this issue Nov 19, 2023 · 3 comments
Open

Document Item Hold Positions #1348

cosmiccoincidence opened this issue Nov 19, 2023 · 3 comments
Labels
Difficulty: Good first issue 🍰 Easy tasks Docs General paperwork.

Comments

@cosmiccoincidence
Copy link
Member

cosmiccoincidence commented Nov 19, 2023

Summary

Document the technical side of the item hold position system.

Goal

Item hold positions are an empty object on item prefabs that indicate the position and rotation of which they should be held by an entity.

Document the system on gitbook under the Systems page and comment the code if needed.

Context

Original PR: #234

Design Doc: https://ss3d.gitbook.io/design/items/hold-positions

@cosmiccoincidence cosmiccoincidence added Feature A new system or other feature. Difficulty: medium 🥼 For those that already have some understanding of the code base. labels Nov 19, 2023
@stilnat
Copy link
Contributor

stilnat commented Nov 19, 2023

this is already in game, but it needs to be properly set for each item. It's currently not the case for all items in game. I suggest maybe turn that issue into a documentation issue for gitbook, explaining how to make a new item, including setting up custom old positions.

@cosmiccoincidence cosmiccoincidence added Docs General paperwork. and removed Feature A new system or other feature. labels Nov 20, 2023
@cosmiccoincidence cosmiccoincidence changed the title Reimplement Item Hold Positions Document Item Hold Positions Nov 20, 2023
@cosmiccoincidence
Copy link
Member Author

cosmiccoincidence commented Dec 2, 2023

It appears the system only supports 2 attachments points per item currently.

image

But preferably the should be able to specify a certain amount per prefab which are based on variables... Design doc: https://ss3d.gitbook.io/design/items/hold-positions

@cosmiccoincidence cosmiccoincidence added Difficulty: Good first issue 🍰 Easy tasks and removed Difficulty: medium 🥼 For those that already have some understanding of the code base. labels Dec 2, 2023
@stilnat
Copy link
Contributor

stilnat commented Oct 23, 2024

On hold since I'm reworking the attachment system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Good first issue 🍰 Easy tasks Docs General paperwork.
Projects
None yet
Development

No branches or pull requests

2 participants