Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve slideshow appearance #8

Open
cosmiccoincidence opened this issue Dec 30, 2023 · 1 comment
Open

Improve slideshow appearance #8

cosmiccoincidence opened this issue Dec 30, 2023 · 1 comment
Assignees
Labels
Feature Good First Issue Good for newcomers.

Comments

@cosmiccoincidence
Copy link
Member

Currently, the slideshow looks and performs a little wonky...

The description bar for the images disappears if there is no description which sounds nice in theory but in practice, this shifts the image thumbnails (that are directly beneath it) down and back up as you pass through images with and without descriptions (as a result it also shift the control arrows for these thumbnails which is annoying). This looks and feels bad.

https://user-images.githubusercontent.com/41941008/118387880-ec864b00-b5ee-11eb-8242-04016a22bbac.gif

An easy fix for this may be to just move the thumbnails above the primary image so there is not part of the slideshow that is beneath the image description. A more proper solution is wanted tho because although no part of the slideshow itself will be getting shifted up/down, the entire rest of the page beneath the slideshow still does, and it just doesn't look/feel good.

@Aneal07
Copy link

Aneal07 commented Dec 30, 2023

assigned it to me, please. I can fix the thumbnail issue as well as smooth transition and responsive design for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Good First Issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants