Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centered Splash Arts corrupted under 13.4.1 #167

Open
Cinzya opened this issue Feb 23, 2023 · 0 comments
Open

Centered Splash Arts corrupted under 13.4.1 #167

Cinzya opened this issue Feb 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Cinzya
Copy link

Cinzya commented Feb 23, 2023

Data Dragon just released a new version, 13.4.1, which leads the backend to download the assets for this new patch.
However, CommunityDragon hasn't come out with a package for 13.4 as of the time of writing, which leads to a dead end, when trying to access material under this version.

image

This affects the centered splash arts, as they are being accessed under the latest major version, which are corrupted when they are downloaded. When inspecting the properties you can see that the centered splash arts are only a few bytes large and reveal following when opened in an text editor:

<html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.18.0 (Ubuntu)</center>
<script defer src="https://static.cloudflareinsights.com/beacon.min.js/vaafb692b2aea4879b33c060e79fe94621666317369993" integrity="sha512-0ahDYl866UMhKuYcW078ScMalXqtFJggm7TmlUtp0UlD4eQk0Ixfnm5ykXKvGJNFjLMoortdseTfsRT8oCfgGA==" data-cf-beacon='{"rayId":"79dcdb576e33b742","token":"1d93d63ea58c4eb382141ef0047426c3","version":"2023.2.0","si":100}' crossorigin="anonymous"></script>
</body>
</html>

image

Changing the source code, to retrieve data from string latest instead of the latest Major/Minor Version would fix this issue and avoid conflicts like this in the future.

lol-pick-ban-ui/backend/data/league/DataDragon.ts

Line 76 in 021b0f3

champion.splashCenteredImg = `https://raw.communitydragon.org/${this.state.getMajorMinorVersion()}/plugins/rcp-be-lol-game-data/global/default/v1/champion-splashes/${champion.key}/${champion.key}000.jpg`;

I'd love to do a pull request, but I think that might be a bit overkill for a one-liner fix :)
@sdomi4 sdomi4 added the enhancement New feature or request label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cinzya @sdomi4