Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple lookups with !lookup #190

Open
stelar7 opened this issue Apr 10, 2019 · 5 comments
Open

Allow multiple lookups with !lookup #190

stelar7 opened this issue Apr 10, 2019 · 5 comments

Comments

@stelar7
Copy link
Contributor

stelar7 commented Apr 10, 2019

Ie. searching for more than one champion at a time
!lookup champion neeko sylas

This should work fine for champions? but would need some special filtering for perks and items as they contain spaces. Another option is to change the syntax, i.e

!lookup champion neeko | sylas

@Querijn
Copy link
Owner

Querijn commented Apr 10, 2019

Anything separated by whitespace or a comma?

@stelar7
Copy link
Contributor Author

stelar7 commented Apr 10, 2019

both whitespace and commas are used in items / perks iirc

@Querijn
Copy link
Owner

Querijn commented Apr 10, 2019

Add options for quotes, I guess, ie "Twisted Fate". Where are comma's used?

@stelar7
Copy link
Contributor Author

stelar7 commented Apr 10, 2019

Seems like i was mistaken about ,, got it confused on BFSword 😅
Id rather prefer a more clear separator like | tho

@Querijn
Copy link
Owner

Querijn commented Apr 10, 2019

It's uncommon in argument parsing, and possibly very confusing for the end user, but you could say the same of comma's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants