Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameters to api call handling #158

Open
stelar7 opened this issue Dec 3, 2018 · 1 comment
Open

Add optional parameters to api call handling #158

stelar7 opened this issue Dec 3, 2018 · 1 comment

Comments

@stelar7
Copy link
Contributor

stelar7 commented Dec 3, 2018

With v4 coming in 60 days, we need to change the encrypted id into a real id. (not possible).

Options;

  • add !{paramname} {param} before/after the url to specify it.
    https://euw1.api.riotgames.com/lol/match/v4/matchlists/by-account/kasdfGSDFhdFGASftW546sefg !summoner Kalturi

  • add the username as the param, instead of the id
    https://euw1.api.riotgames.com/lol/match/v4/matchlists/by-account/Kalturi

@Querijn
Copy link
Owner

Querijn commented Apr 30, 2019

I have something in the works for this. I'll take this one.

@Querijn Querijn assigned Querijn and unassigned Querijn Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants