Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe hash upon account creation #25

Open
scalzava opened this issue May 15, 2024 · 0 comments
Open

Unsafe hash upon account creation #25

scalzava opened this issue May 15, 2024 · 0 comments

Comments

@scalzava
Copy link

Describe the bug
Our security team is working on the automated detection of session vulnerabilities in opensource web applications, including insecure hashing of authentication credentials. Our analyzer identified that the set_password function of BikenWeb/biken
/models.py is using an unsafe hashing function (SHA-256) to store users' passwords. This practice might leave your application vulnerable to offline bruteforcing attacks.

Can you take a look into the relevant code parts and comment on the issue?

To Reproduce
Upon data breach, an attacker with access to the password database can perform offline bruteforcing to reconstruct valid users' passwords, possibly reused at other services. This can be avoided by using more secure hashing algorithms.

Expected behavior
Please follow the OWASP recommendations for secure password hashing to avoid the issue: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant