Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large error in calculation of double integral. #61

Open
amanabt opened this issue Oct 22, 2017 · 1 comment
Open

Large error in calculation of double integral. #61

amanabt opened this issue Oct 22, 2017 · 1 comment
Assignees
Labels

Comments

@amanabt
Copy link
Member

amanabt commented Oct 22, 2017

Commit: 3b42c3f

Issue:
The error in the calculation of double integral image
is of the order of image in the test_wave_equation_2d.py::test_A_matrix unit test.

As of now, the cause of the issue is not known.

@amanabt
Copy link
Member Author

amanabt commented Oct 23, 2017

The reference values were calculated using the LGL points with an accuracy of 1e-4,
whereas, the unit test was using LGL points with an accuracy of machine error. The
difference in accuracy of the LGL points lead to large errors b/w reference and test
A matrix.

Recalculating the reference values using LGL points with higher accuracy reduced the
error b/w reference and test A matrix to machine error.

Issue fixed in PR #44

@amanabt amanabt added this to the 2D Wave equation solver. milestone Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants