Skip to content

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Sep 4, 2025

This actually failed for me locally which is interesting/concerning. It would be great to support newer cuTENSOR and CUDA.jl as a lot of updates have happened there.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt
Copy link
Member Author

kshyatt commented Sep 4, 2025 via email

@lkdvos
Copy link
Member

lkdvos commented Sep 4, 2025

No, the cuTENSOR.jl wrappers were restricted to DenseCuArray types before the PR I linked, and we are wrapping everything in CuStridedView = StridedView{<:CuArray}, which is not a subtype of that unfortunately.

@kshyatt
Copy link
Member Author

kshyatt commented Sep 4, 2025

Ah ok I see, I'll restore the minimum version then

@Jutho
Copy link
Member

Jutho commented Nov 17, 2025

@kshyatt , completely forgot about this one. I assume this is still good to be merged as is?

@kshyatt
Copy link
Member Author

kshyatt commented Nov 17, 2025

Let's resolve the conflict and make sure tests still pass, but then yes, should be good.

@kshyatt kshyatt enabled auto-merge (squash) November 17, 2025 15:47
@kshyatt kshyatt merged commit 9208adc into master Nov 17, 2025
15 checks passed
@kshyatt kshyatt deleted the ksh/cutensor_bump branch November 17, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants