-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SubDitStr
function to enable DitStr
slicing
#54
Conversation
This is related to (#53) |
Sorry that I may have accidentally modified some other lines with my auto formatting tool :( |
Thank you for the contribution! The code quality is pretty good. I am wondering if there is a practical using case for this feature? |
I am using Hence, a The former implementation of slicing relys on the |
This PR is still WIP, just push here to see if it is a suitable solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature seems to be useful, and is throughly tested. I am wondering if it is beneficial to add some eye candies like bit_string[start:stop]
?
* new `DitStr` function to raise `SubDitStr` struct to `DitStr` * tests added
This is the last commit for this PR. If the code is approved, I hope it can be merged with a version bump. Thanks a lot for your review and kind help! |
Will this commit be approved now? |
I just merged this PR and will tag a new patch version later. |
Thanks! |
I studied the official implementation of
SubStrings
in Julia's Base library SubString.jlI think same implementation can be added into
BitBasis.jl
for high performance slicing, so I imitated the implementation in the Base Library in this PR