Skip to content

Conversation

@Hind-M
Copy link
Collaborator

@Hind-M Hind-M commented Dec 26, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.34911% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@95daf01). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/array_deserializer.cpp 86.61% 17 Missing ⚠️
src/deserialize.cpp 80.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage        ?   83.35%           
=======================================
  Files           ?       44           
  Lines           ?     1994           
  Branches        ?        0           
=======================================
  Hits            ?     1662           
  Misses          ?      332           
  Partials        ?        0           
Flag Coverage Δ
unittests 83.35% <89.34%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Alex-PLACET Alex-PLACET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark about the implementation location

Copy link
Contributor

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array_deserializer_impl.hpp should be renamed into array_deserializer.hpp

@Hind-M Hind-M merged commit 587c242 into sparrow-org:main Jan 6, 2026
27 of 29 checks passed
@Hind-M Hind-M deleted the refactor branch January 6, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants